gh-107831: Fix inspect.getcallargs accepting positional-only args by keyword#151900
Open
iamsharduld wants to merge 1 commit into
Open
gh-107831: Fix inspect.getcallargs accepting positional-only args by keyword#151900iamsharduld wants to merge 1 commit into
iamsharduld wants to merge 1 commit into
Conversation
…gs by keyword getcallargs() built the set of acceptable keyword names from getfullargspec's 'args', which includes positional-only parameters, so a positional-only parameter could be filled by keyword without error -- unlike an actual call or Signature.bind(). Exclude positional-only names (derived from the code object's co_posonlyargcount) from keyword matching and raise the same TypeError the interpreter does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspect.getcallargs()built its set of acceptable keyword names fromgetfullargspec'sargs, which includes positional-only parameters, so apositional-only parameter could be filled by keyword without error -- unlike an
actual call or
Signature.bind():Derive the positional-only names from the code object's
co_posonlyargcount,exclude them from keyword matching, and raise the same
TypeErrortheinterpreter does. The behaviour was checked against real calls (exception type
and message) for functions, methods, and the case where
**kwargsabsorbs thename.
inspect.getcallargsdoes not raiseTypeErrorfor pos-only passed as keywords #107831